Page MenuHomePhabricator
Differential D6831

[native] Don't prompt SIWE users about keeping login info on logout
ClosedPublic
Actions

Authored by atul on Feb 21 2023, 11:35 PM.
Tags
None
Referenced Files
F3513366: D6831.diff
Sat, Dec 21, 11:56 PM
Unknown Object (File)
Fri, Nov 22, 1:44 AM
Unknown Object (File)
Fri, Nov 22, 1:44 AM
Unknown Object (File)
Fri, Nov 22, 1:44 AM
Unknown Object (File)
Fri, Nov 22, 1:43 AM
Unknown Object (File)
Fri, Nov 22, 1:41 AM
Unknown Object (File)
Nov 20 2024, 1:45 AM
Unknown Object (File)
Nov 8 2024, 4:44 AM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM9b18b40e786e: [native] Don't prompt SIWE users about keeping login info on logout
Summary

Context: https://linear.app/comm/issue/ENG-2799/on-native-log-out-dont-prompt-siwe-users-about-keeping-login-info-in

Basically there are no native credentials to be kept or removed, so the existing Alert is irrelevant.

Instead added an "are you sure you want to log out" Alert since immediately logging out (destructive action) without any confirmation was a bit jarring.

Test Plan

Here's how it looks when a SIWE user taps "Sign out":

Simulator Screen Shot - iPhone 14 Pro - 2023-02-21 at 23.32.16.png (2×1 px, 331 KB)

Here's how it looks when a "traditional" user taps "Sign out":

Simulator Screen Shot - iPhone 14 Pro - 2023-02-21 at 23.33.28.png (2×1 px, 500 KB)

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D6831 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Feb 21 2023, 11:35 PM
atul published this revision for review.Feb 21 2023, 11:37 PM
atul added inline comments.
native/profile/profile-screen.react.js
180–181 ↗(On Diff #22916)

Just improvised with the copy here, happy to change it to whatever

CC @ashoat

185 ↗(On Diff #22916)

Maybe instead of "No" vs "Yes" we could do "Cancel" vs "Log out"?

Open to anything

Harbormaster completed remote builds in B16756: Diff 22916.Feb 21 2023, 11:50 PM
atul edited the test plan for this revision. (Show Details)Feb 22 2023, 12:48 AM
ashoat accepted this revision.Feb 22 2023, 11:11 AM

Copy seems fine, defer to you on Yes/No vs. Cancel/Log out

This revision is now accepted and ready to land.Feb 22 2023, 11:11 AM
atul updated this revision to Diff 22949.Feb 22 2023, 2:59 PM

rebase + land

This revision was landed with ongoing or failed builds.Feb 22 2023, 2:59 PM
Closed by commit rCOMM9b18b40e786e: [native] Don't prompt SIWE users about keeping login info on logout (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM9b18b40e786e: [native] Don't prompt SIWE users about keeping login info on logout.
Harbormaster completed remote builds in B16786: Diff 22949.Feb 22 2023, 3:14 PM

Revision Contents
Changeset List

PathSize
native/
profile/
28 lines

Diff 22949

View Options

native/profile/profile-screen.react.js

Loading...