[native] Don't prompt SIWE users about keeping login info on logout
ClosedPublic
Actions

Authored by atul on Feb 21 2023, 11:35 PM.

Details

Reviewers

ashoat
tomek

Commits

rCOMM9b18b40e786e: [native] Don't prompt SIWE users about keeping login info on logout

Summary

Context: https://linear.app/comm/issue/ENG-2799/on-native-log-out-dont-prompt-siwe-users-about-keeping-login-info-in

Basically there are no native credentials to be kept or removed, so the existing Alert is irrelevant.

Instead added an "are you sure you want to log out" Alert since immediately logging out (destructive action) without any confirmation was a bit jarring.

Test Plan

Here's how it looks when a SIWE user taps "Sign out":

Simulator Screen Shot - iPhone 14 Pro - 2023-02-21 at 23.32.16.png (2×1 px, 331 KB)

Here's how it looks when a "traditional" user taps "Sign out":

Simulator Screen Shot - iPhone 14 Pro - 2023-02-21 at 23.33.28.png (2×1 px, 500 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Feb 21 2023, 11:35 PM

atul published this revision for review.Feb 21 2023, 11:37 PM

atul added inline comments.

native/profile/profile-screen.react.js
180–181 ↗	(On Diff #22916)	Just improvised with the copy here, happy to change it to whatever CC @ashoat
185 ↗	(On Diff #22916)	Maybe instead of "No" vs "Yes" we could do "Cancel" vs "Log out"? Open to anything