Page MenuHomePhabricator

[lib] Require `primaryIdentityPublicKey` in `SIWEStatement`
ClosedPublic

Authored by atul on Feb 21 2023, 8:25 PM.
Tags
None
Referenced Files
F3492612: D6826.diff
Thu, Dec 19, 12:49 AM
Unknown Object (File)
Sat, Dec 14, 7:05 AM
Unknown Object (File)
Fri, Nov 22, 1:44 AM
Unknown Object (File)
Fri, Nov 22, 1:43 AM
Unknown Object (File)
Fri, Nov 22, 1:43 AM
Unknown Object (File)
Fri, Nov 22, 1:43 AM
Unknown Object (File)
Fri, Nov 22, 1:41 AM
Unknown Object (File)
Nov 12 2024, 11:55 PM
Subscribers
None

Details

Summary

We were previously accepting SIWEMessages without primaryIdentityPublicKey before we were able to integrate olm into web. Now that we've been able to integrate olm into web and are always including the primaryIdentityPublicKey in the SIWEMessage statement, we can validate that it's being included.

We don't have to worry about native clients that aren't including primaryIdentityPublicKey because none were publicly released.

Test Plan

Able to SIWE on both web and native without issue (against local keyserver).

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage