Page MenuHomePhabricator

[web] Pass `signedIdentityKeysBlob` to `keyserver` on `siwe_auth`
ClosedPublic

Authored by atul on Feb 24 2023, 11:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 2:22 AM
Unknown Object (File)
Thu, Dec 19, 2:16 AM
Unknown Object (File)
Thu, Dec 19, 1:34 AM
Unknown Object (File)
Wed, Dec 18, 11:06 PM
Unknown Object (File)
Fri, Nov 22, 1:21 AM
Unknown Object (File)
Fri, Nov 22, 1:21 AM
Unknown Object (File)
Fri, Nov 22, 1:21 AM
Unknown Object (File)
Fri, Nov 22, 1:21 AM
Subscribers
None

Details

Summary

Include signedIdentityKeysBlob in siwe_auth request and update siweAuthRequestInputValidator to accept signedIdentityKeysBlob. Right now we don't do anything with the signedIdentityKeysBlob, but it's being passed to keyserver from web when hitting both login and siwe_auth endpoints.

Next up is

  1. Making sure that signedIdentityKeysBlob is valid (regex checks)
  2. Pulling out primary.ed25519 and verifying the payload signature (maybe an argument for leaving primaryIdentityPublicKey as part of the login request and maybe adding it to siwe_auth?)
  3. Stringifying the entire signedIdentityKeysBlob and storing it in the serverDB (going to do a migration to remove existing stuff first).

Depends on D6895

Test Plan

Set breakpoint in siweAuthResponder and observed that signedIdentityKeysBlob "made it through" and validator successfully validated request:

d5802c.png (1×2 px, 814 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul requested review of this revision.Feb 24 2023, 11:46 PM
This revision is now accepted and ready to land.Feb 26 2023, 5:40 AM

PS looks like a missing screenshot in the Test Plan.

And RE this:

validator successfully validated request

Would be good to also validate that the signature can be verified on the keyserver side, but that can be done at a later step.

PS looks like a missing screenshot in the Test Plan.

Dang, swore I dragged it in... anyways updated Test Plan with screenshot

This revision was landed with ongoing or failed builds.Feb 26 2023, 6:03 PM
This revision was automatically updated to reflect the committed changes.