Page MenuHomePhabricator
Differential D6901

[keyserver] Introduce `getOLMUtility(...)` and initialize OLM on `keyserver` start
ClosedPublic
Actions

Authored by atul on Feb 27 2023, 1:57 PM.
Tags
None
Referenced Files
F5102343: D6901.diff
Mon, Mar 31, 5:22 PM
Unknown Object (File)
Wed, Mar 26, 7:08 AM
Unknown Object (File)
Sun, Mar 2, 8:58 PM
Unknown Object (File)
Feb 24 2025, 11:01 PM
Unknown Object (File)
Jan 30 2025, 4:33 PM
Unknown Object (File)
Jan 30 2025, 4:33 PM
Unknown Object (File)
Jan 30 2025, 4:33 PM
Unknown Object (File)
Jan 30 2025, 4:33 PM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM06732ac6a7f2: [keyserver] Introduce `getOLMUtility(...)` and initialize OLM on `keyserver`…
Summary

Initialize OLM by calling await olm.init() on keyserver start and introduce getOLMUtility to potentially access cached OLMUtility... or instantiate a new one.

Test Plan
  • Logged in a bunch of times and ensured things worked as expected.
  • Set breakpoint on cache hit:

8fe3ee.png (632×1 px, 147 KB)

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Feb 27 2023, 1:57 PM
atul published this revision for review.Feb 27 2023, 1:58 PM
atul mentioned this in D6897: [keyserver] Verify `signedIdentityKeysBlob` signature in `logInResponder`.
atul updated this revision to Diff 23179.Feb 27 2023, 1:59 PM

annotate

atul edited the test plan for this revision. (Show Details)Feb 27 2023, 1:59 PM
Harbormaster completed remote builds in B16957: Diff 23178.Feb 27 2023, 2:13 PM
Harbormaster completed remote builds in B16958: Diff 23179.
ashoat accepted this revision.Feb 27 2023, 2:35 PM
This revision is now accepted and ready to land.Feb 27 2023, 2:35 PM
atul updated this revision to Diff 23188.Feb 27 2023, 3:20 PM

rebase + land

This revision was landed with ongoing or failed builds.Feb 27 2023, 3:20 PM
Closed by commit rCOMM06732ac6a7f2: [keyserver] Introduce `getOLMUtility(...)` and initialize OLM on `keyserver`… (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM06732ac6a7f2: [keyserver] Introduce `getOLMUtility(...)` and initialize OLM on `keyserver`….
Harbormaster completed remote builds in B16965: Diff 23188.Feb 27 2023, 3:34 PM
ashoat mentioned this in D6923: [keyserver] Tunnelbroker integration - Adding Tunnelbroker publisher and connector.Mar 2 2023, 7:53 AM

Revision Contents
Changeset List

PathSize
keyserver/
src/
2 lines
responders/
6 lines
utils/
12 lines

Diff 23179

View Options

keyserver/src/keyserver.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import type { import type {
ChangeThreadSettingsPayload, ChangeThreadSettingsPayload,
LeaveThreadPayload, LeaveThreadPayload,
UpdateThreadRequest, UpdateThreadRequest,
ClientNewThreadRequest, ClientNewThreadRequest,
NewThreadResult, NewThreadResult,
ClientThreadJoinRequest, ClientThreadJoinRequest,
ThreadJoinPayload, ThreadJoinPayload,
ThreadFetchMediaRequest, ThreadFetchMediaRequest,
ThreadFetchMediaResult, ThreadFetchMediaResult,
ToggleMessagePinRequest,
} from '../types/thread-types.js'; } from '../types/thread-types.js';
import type { CallServerEndpoint } from '../utils/call-server-endpoint.js'; import type { CallServerEndpoint } from '../utils/call-server-endpoint.js';
import { values } from '../utils/objects.js'; import { values } from '../utils/objects.js';
const deleteThreadActionTypes = Object.freeze({ const deleteThreadActionTypes = Object.freeze({
started: 'DELETE_THREAD_STARTED', started: 'DELETE_THREAD_STARTED',
success: 'DELETE_THREAD_SUCCESS', success: 'DELETE_THREAD_SUCCESS',
failed: 'DELETE_THREAD_FAILED', failed: 'DELETE_THREAD_FAILED',
▲ Show 20 Lines • Show All 146 Lines • ▼ Show 20 Linesconst fetchThreadMedia =
( (
callServerEndpoint: CallServerEndpoint, callServerEndpoint: CallServerEndpoint,
): ((request: ThreadFetchMediaRequest) => Promise<ThreadFetchMediaResult>) => ): ((request: ThreadFetchMediaRequest) => Promise<ThreadFetchMediaResult>) =>
async request => { async request => {
const response = await callServerEndpoint('fetch_thread_media', request); const response = await callServerEndpoint('fetch_thread_media', request);
return response; return response;
}; };
const toggleMessagePin =
(
callServerEndpoint: CallServerEndpoint,
): ((request: ToggleMessagePinRequest) => Promise<void>) =>
async request => {
await callServerEndpoint('toggle_message_pin', request);
};
export { export {
deleteThreadActionTypes, deleteThreadActionTypes,
deleteThread, deleteThread,
changeThreadSettingsActionTypes, changeThreadSettingsActionTypes,
changeThreadSettings, changeThreadSettings,
removeUsersFromThreadActionTypes, removeUsersFromThreadActionTypes,
removeUsersFromThread, removeUsersFromThread,
changeThreadMemberRolesActionTypes, changeThreadMemberRolesActionTypes,
changeThreadMemberRoles, changeThreadMemberRoles,
newThreadActionTypes, newThreadActionTypes,
newThread, newThread,
joinThreadActionTypes, joinThreadActionTypes,
joinThread, joinThread,
leaveThreadActionTypes, leaveThreadActionTypes,
leaveThread, leaveThread,
fetchThreadMedia, fetchThreadMedia,
toggleMessagePin,
}; };
View Options

keyserver/src/responders/user-responders.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import type { import type {
ChangeThreadSettingsPayload, ChangeThreadSettingsPayload,
LeaveThreadPayload, LeaveThreadPayload,
UpdateThreadRequest, UpdateThreadRequest,
ClientNewThreadRequest, ClientNewThreadRequest,
NewThreadResult, NewThreadResult,
ClientThreadJoinRequest, ClientThreadJoinRequest,
ThreadJoinPayload, ThreadJoinPayload,
ThreadFetchMediaRequest, ThreadFetchMediaRequest,
ThreadFetchMediaResult, ThreadFetchMediaResult,
ToggleMessagePinRequest,
} from '../types/thread-types.js'; } from '../types/thread-types.js';
import type { CallServerEndpoint } from '../utils/call-server-endpoint.js'; import type { CallServerEndpoint } from '../utils/call-server-endpoint.js';
import { values } from '../utils/objects.js'; import { values } from '../utils/objects.js';
const deleteThreadActionTypes = Object.freeze({ const deleteThreadActionTypes = Object.freeze({
started: 'DELETE_THREAD_STARTED', started: 'DELETE_THREAD_STARTED',
success: 'DELETE_THREAD_SUCCESS', success: 'DELETE_THREAD_SUCCESS',
failed: 'DELETE_THREAD_FAILED', failed: 'DELETE_THREAD_FAILED',
▲ Show 20 Lines • Show All 146 Lines • ▼ Show 20 Linesconst fetchThreadMedia =
( (
callServerEndpoint: CallServerEndpoint, callServerEndpoint: CallServerEndpoint,
): ((request: ThreadFetchMediaRequest) => Promise<ThreadFetchMediaResult>) => ): ((request: ThreadFetchMediaRequest) => Promise<ThreadFetchMediaResult>) =>
async request => { async request => {
const response = await callServerEndpoint('fetch_thread_media', request); const response = await callServerEndpoint('fetch_thread_media', request);
return response; return response;
}; };
const toggleMessagePin =
(
callServerEndpoint: CallServerEndpoint,
): ((request: ToggleMessagePinRequest) => Promise<void>) =>
async request => {
await callServerEndpoint('toggle_message_pin', request);
};
export { export {
deleteThreadActionTypes, deleteThreadActionTypes,
deleteThread, deleteThread,
changeThreadSettingsActionTypes, changeThreadSettingsActionTypes,
changeThreadSettings, changeThreadSettings,
removeUsersFromThreadActionTypes, removeUsersFromThreadActionTypes,
removeUsersFromThread, removeUsersFromThread,
changeThreadMemberRolesActionTypes, changeThreadMemberRolesActionTypes,
changeThreadMemberRoles, changeThreadMemberRoles,
newThreadActionTypes, newThreadActionTypes,
newThread, newThread,
joinThreadActionTypes, joinThreadActionTypes,
joinThread, joinThread,
leaveThreadActionTypes, leaveThreadActionTypes,
leaveThread, leaveThread,
fetchThreadMedia, fetchThreadMedia,
toggleMessagePin,
}; };
View Options

keyserver/src/utils/olm-utils.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import type { import type {
ChangeThreadSettingsPayload, ChangeThreadSettingsPayload,
LeaveThreadPayload, LeaveThreadPayload,
UpdateThreadRequest, UpdateThreadRequest,
ClientNewThreadRequest, ClientNewThreadRequest,
NewThreadResult, NewThreadResult,
ClientThreadJoinRequest, ClientThreadJoinRequest,
ThreadJoinPayload, ThreadJoinPayload,
ThreadFetchMediaRequest, ThreadFetchMediaRequest,
ThreadFetchMediaResult, ThreadFetchMediaResult,
ToggleMessagePinRequest,
} from '../types/thread-types.js'; } from '../types/thread-types.js';
import type { CallServerEndpoint } from '../utils/call-server-endpoint.js'; import type { CallServerEndpoint } from '../utils/call-server-endpoint.js';
import { values } from '../utils/objects.js'; import { values } from '../utils/objects.js';
const deleteThreadActionTypes = Object.freeze({ const deleteThreadActionTypes = Object.freeze({
started: 'DELETE_THREAD_STARTED', started: 'DELETE_THREAD_STARTED',
success: 'DELETE_THREAD_SUCCESS', success: 'DELETE_THREAD_SUCCESS',
failed: 'DELETE_THREAD_FAILED', failed: 'DELETE_THREAD_FAILED',
▲ Show 20 Lines • Show All 146 Lines • ▼ Show 20 Linesconst fetchThreadMedia =
( (
callServerEndpoint: CallServerEndpoint, callServerEndpoint: CallServerEndpoint,
): ((request: ThreadFetchMediaRequest) => Promise<ThreadFetchMediaResult>) => ): ((request: ThreadFetchMediaRequest) => Promise<ThreadFetchMediaResult>) =>
async request => { async request => {
const response = await callServerEndpoint('fetch_thread_media', request); const response = await callServerEndpoint('fetch_thread_media', request);
return response; return response;
}; };
const toggleMessagePin =
(
callServerEndpoint: CallServerEndpoint,
): ((request: ToggleMessagePinRequest) => Promise<void>) =>
async request => {
await callServerEndpoint('toggle_message_pin', request);
};
export { export {
deleteThreadActionTypes, deleteThreadActionTypes,
deleteThread, deleteThread,
changeThreadSettingsActionTypes, changeThreadSettingsActionTypes,
changeThreadSettings, changeThreadSettings,
removeUsersFromThreadActionTypes, removeUsersFromThreadActionTypes,
removeUsersFromThread, removeUsersFromThread,
changeThreadMemberRolesActionTypes, changeThreadMemberRolesActionTypes,
changeThreadMemberRoles, changeThreadMemberRoles,
newThreadActionTypes, newThreadActionTypes,
newThread, newThread,
joinThreadActionTypes, joinThreadActionTypes,
joinThread, joinThread,
leaveThreadActionTypes, leaveThreadActionTypes,
leaveThread, leaveThread,
fetchThreadMedia, fetchThreadMedia,
toggleMessagePin,
}; };