Page MenuHomePhabricator
Differential D6906

[keyserver] Ignore `primaryIdentityPublicKey` at `login`/`register`/`siwe_auth` endpoints
ClosedPublic
Actions

Authored by atul on Feb 27 2023, 3:43 PM.
Tags
None
Referenced Files
F2158162: D6906.id23203.diff
Mon, Jul 1, 3:17 AM
Unknown Object (File)
Sat, Jun 15, 3:17 AM
Unknown Object (File)
Fri, Jun 14, 7:10 PM
Unknown Object (File)
Thu, Jun 13, 7:19 PM
Unknown Object (File)
Tue, Jun 11, 2:46 PM
Unknown Object (File)
May 18 2024, 3:03 PM
Unknown Object (File)
May 12 2024, 6:10 AM
Unknown Object (File)
May 11 2024, 10:31 AM
View All 62 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMMca5a871c35cd: [keyserver] Ignore `primaryIdentityPublicKey` at `login`/`register`/`siwe_auth`…
Summary

Remove handling of primaryIdentityPublicKey and stop persisting in public_key column of cookies table.

Test Plan

Can still register/login/SIWE as expected. primaryIdentityPublicKey is still accepted in validators so old clients will continue working.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Feb 27 2023, 3:43 PM
atul added inline comments.Feb 27 2023, 3:44 PM
keyserver/src/responders/user-responders.js
460–464

We're still going to pull public key from the SIWE statement and compare against the IdentityKeysBlob.primary.ed25519 in subsequent diff.

Using the eslint-disable for now to avoid unnecessary refactoring

atul published this revision for review.Feb 27 2023, 3:44 PM
Harbormaster completed remote builds in B16967: Diff 23192.Feb 27 2023, 3:58 PM
ashoat accepted this revision.Feb 27 2023, 4:18 PM
This revision is now accepted and ready to land.Feb 27 2023, 4:18 PM
atul updated this revision to Diff 23203.Feb 27 2023, 4:51 PM

rebase + land

This revision was landed with ongoing or failed builds.Feb 27 2023, 4:51 PM
Closed by commit rCOMMca5a871c35cd: [keyserver] Ignore `primaryIdentityPublicKey` at `login`/`register`/`siwe_auth`… (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMca5a871c35cd: [keyserver] Ignore `primaryIdentityPublicKey` at `login`/`register`/`siwe_auth`….
Harbormaster completed remote builds in B16969: Diff 23203.Feb 27 2023, 5:06 PM

Revision Contents
Changeset List

PathSize
keyserver/
src/
creators/
4 lines
responders/
16 lines
session/
11 lines
lib/
types/
1 line

Diff 23192

View Options

keyserver/src/creators/account-creator.js

Loading...
View Options

keyserver/src/responders/user-responders.js

Loading...
View Options

keyserver/src/session/cookies.js

Loading...
View Options

lib/types/account-types.js

Loading...