identityKeysBlobValidator ensures that the structure of the JSON.parse()d signedIdentityKeysBlob.payload is correct and throws a ServerError if it isn't.
Details
Details
Made sure login/register/siwe_auth works on native. Made sure login/siwe_auth works on web.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- arcpatch-D6950_1 (branched from master)
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/utils/crypto-utils.js | ||
|---|---|---|
| 3 ↗ | (On Diff #23409) | Any reason this is in lib instead of keyserver? I don't think it will be included in JS bundles, so no serious concern... but I can't imagine this function being called outside of keyserver (let me know if I'm missing something) |
| lib/utils/crypto-utils.js | ||
|---|---|---|
| 3 ↗ | (On Diff #23409) | That's fair, we do only use these validators on the keyserver. I guess my reasoning was A. We already have a crypto-utils.js in lib so one less crypto-utils.js file. but neither reason is great. I'll create a separate crypto-utils in keyserver. (Also considered putting these in validation-utils, but I thought it'd be better to keep that "general purpose" with general utilities like tRegex and tNumEnum instead of cluttering it up with like "business logic specific" validators.) |