@anunay is going to extend these. Mostly inspired by TypeScript types.
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Noted some inconsistencies with the TypeScript types. Feel free to re-request review if the omissions were intentional.
| keyserver/flow-typed/npm/@matrix-org/olm_vx.x.x.js | ||
|---|---|---|
| 17–19 | Looks like we're missing unpublished_fallback_key(): string; forget_old_fallback_key(): void; in between fallback_key() and pickle(...). Let me know if I'm missing something here. | |
| 39 | Can we do this instead of Object to match TypeScript types:  ? Let me know if I'm missing something here. | |
| 58 | Can we do this instead of Object to match TypeScript types:  ? Let me know if I'm missing something here. | |
| 80 | Can we do this instead of Object to match TypeScript types:  ? Let me know if I'm missing something here. | |
| 108–109 | Looks like we're missing calculate_mac_fixed_base64(input: string, info: string): string; in between calculate_mac and calculate_mac_long_kdf | |
Comment Actions
I pulled this from the version of the types in node_modules. Will try to make those improvements, with exceptions for any methods that might not exist in this older version of Olm (I think you're looking at master, which I linked above)
| keyserver/flow-typed/npm/@matrix-org/olm_vx.x.x.js | ||
|---|---|---|
| 17–19 | Ran these commands to confirm that this doesn't exist on our version of Olm (3.2.4): cd web/node_modules/\@matrix-org/olm/ grep -R unpublished_fallback_key . grep -R forget_old_fallback_key . I'm a little worried about using a different versions of Olm in different parts of our app. It's ultimately unavoidable (ie. if we upgrade keyserver and native at the same time, we'll still have some old clients running the old version), but it seems like a good idea to keep our versions generally in sync. The latest version of Olm is actually 3.2.14, so arguably we should just upgrade everything. I think @anunay has been working off of master, as I recall him mentioning forget_old_fallback_key. I'll try to put up a diff ahead of this one that upgrades our versions of Olm. | |