Page MenuHomePhabricator
Differential D7604

[lib] Make threadInfo.roles read-only
ClosedPublic
Actions

Authored by ashoat on Apr 25 2023, 4:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 4, 3:56 PM
Unknown Object (File)
Tue, Oct 1, 1:30 PM
Unknown Object (File)
Tue, Oct 1, 1:30 PM
Unknown Object (File)
Tue, Oct 1, 1:30 PM
Unknown Object (File)
Tue, Oct 1, 1:29 PM
Unknown Object (File)
Tue, Oct 1, 12:07 PM
Unknown Object (File)
Sun, Sep 22, 2:48 PM
Unknown Object (File)
Mon, Sep 16, 5:40 PM
View All 67 Files
Subscribers
None

Details

Reviewers
atul
tomek
Commits
rCOMM02d10a36bf01: [lib] Make threadInfo.roles read-only
Summary

Noticed this in D7601.

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/readonlyroles
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Apr 25 2023, 4:06 AM
Harbormaster completed remote builds in B18731: Diff 25653.Apr 25 2023, 4:23 AM
ashoat requested review of this revision.Apr 25 2023, 4:23 AM
atul accepted this revision.Apr 25 2023, 10:42 AM

Thanks for catching this

This revision is now accepted and ready to land.Apr 25 2023, 10:42 AM
Closed by commit rCOMM02d10a36bf01: [lib] Make threadInfo.roles read-only (authored by ashoat). · Explain WhyApr 25 2023, 12:36 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM02d10a36bf01: [lib] Make threadInfo.roles read-only.

Revision Contents
Changeset List

PathSize
lib/
types/
8 lines

Diff 25653

View Options

lib/types/thread-types.js

Loading...