Remove check for even code version when deciding on rescind payload structure
ClosedPublic
Actions

Authored by marcin on Jul 31 2023, 3:50 AM.

Details

Reviewers

tomek
ashoat

Commits

rCOMM133aed97d2c6: Remove check for even code version when deciding on rescind payload structure

Summary

Comprehensive explantion on why this change was necessary can be found in this comment: https://linear.app/comm/issue/ENG-4453#comment-a68b5cf6.

Test Plan

Change NEXT_CODE_VERSION to zero in version-utils.js.
Build iOS app with odd code version.
Ensure encrypoted rescidns work

Diff Detail

Repository

rCOMM Comm

Branch

marcin/eng-4453

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Jul 31 2023, 3:50 AM

Harbormaster completed remote builds in B21358: Diff 29261.Jul 31 2023, 4:10 AM

marcin requested review of this revision.Jul 31 2023, 4:10 AM

ashoat accepted this revision.Jul 31 2023, 8:32 AM

This revision is now accepted and ready to land.Jul 31 2023, 8:32 AM

Rebase before landing

Harbormaster completed remote builds in B21451: Diff 29423.Aug 1 2023, 5:59 AM

Harbormaster completed remote builds in B21452: Diff 29425.Aug 1 2023, 6:08 AM

Closed by commit rCOMM133aed97d2c6: Remove check for even code version when deciding on rescind payload structure (authored by marcin). · Explain WhyAug 1 2023, 6:11 AM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMM133aed97d2c6: Remove check for even code version when deciding on rescind payload structure.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

push/

rescind.js

6 lines

Diff 29423

View Options

keyserver/src/push/rescind.js

Remove check for even code version when deciding on rescind payload structureClosedPublicActions