D9178 broke this by requiring [content.userInfo[@"id"] to be non-nil in NotificationService.mm.
This diff makes it possible for that value to be nil without crashing the NSE.
Details
Details
- Reviewers
atul - Commits
- rCOMM4a1baebbbe0f: [native] Fix rescinds and badge-only notifs on iOS
- I managed to reproduce the issue in my local environment
- I then attached the Xcode debugger to the NSE, following the instructions here
- After my diff, I confirmed that the issue no longer occurs
- I also confirmed in the debugger that the value of [content.userInfo[@"id"] was in fact nil
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- ashoat/rescinds
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Was there maybe some corresponding keyserver change that needed to be deployed before this release or something?
| native/ios/NotificationService/NotificationService.mm | ||
|---|---|---|
| 76–78 | Nit: I think generally we construct std::strings via eg std::ostringstream instead of + operator to avoid reallocating, but I think the performance overhead here is minimal so it doesn't matter and it was what was already there so it's probably not worth changing. | |