[SIWE] Differentiate content for social proof and backup message.
ClosedPublic
Actions

Authored by marcin on Apr 24 2024, 5:10 AM.

Details

Reviewers

ashoat

Commits

Summary

This differential introduces different SIWE message content for social proof and backup message.

Test Plan

Ensure that siwe-utils.test.js pass during commit.
I executed SIWE login flow and ensured that messages that appear in rainbow app match expected content.

Repository

rCOMM Comm

Branch

marcin/eng-7930

Lint

No Lint Coverage

Unit

No Test Coverage

Screen shot of rainbow app during social proof signature generation:

Screen shot of rainbow app during backup message signature generation:

marcin requested review of this revision.Apr 24 2024, 5:26 AM

ashoat added inline comments.

lib/utils/siwe-utils.js
83 ↗	(On Diff #39434)	Can we use a more specific type here?
96–99 ↗	(On Diff #39434)	If we can't use a more specific type easily, then maybe instead you can add an `invariant` here to make sure that the `messageType` is either one or the other option

This revision is now accepted and ready to land.Apr 24 2024, 6:29 PM

lib/utils/siwe-utils.js
83 ↗	(On Diff #39434)	Invariant can be avoided here and more specific type can be used. However this value is extracted from WebView headers in `landing-handler`. Therefore in order to avoid invariant here we will need to cast from string to `SIWEMEssageType` in `landing-handler`. This casting will have to use `any`. In my opinion it should be safe since in `landing-handler` we will use validator anyway before casting.
96–99 ↗	(On Diff #39434)	I think the `invariant` you are requesting is already added at line 89.