Page MenuHomePhabricator

[lib] Rename Neynar types
ClosedPublic

Authored by ashoat on May 5 2024, 12:09 PM.
Tags
None
Referenced Files
F3518539: D11875.id39809.diff
Sun, Dec 22, 8:15 PM
Unknown Object (File)
Thu, Dec 19, 9:30 AM
Unknown Object (File)
Thu, Dec 19, 9:30 AM
Unknown Object (File)
Thu, Dec 19, 9:30 AM
Unknown Object (File)
Thu, Dec 19, 9:30 AM
Unknown Object (File)
Thu, Dec 19, 9:30 AM
Unknown Object (File)
Nov 11 2024, 3:23 PM
Unknown Object (File)
Nov 11 2024, 1:07 PM
Subscribers

Details

Summary

We are using FarcasterUser as a type name elsewhere in the codebase, and I'm about to introduce a query that will return users from Neynar but without the ViewerContext.

Figured these names would be less ambiguous, but open to other ideas.

Depends on D11874

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Figured these names would be less ambiguous, but open to other ideas.

These names make sense to me

This revision is now accepted and ready to land.May 5 2024, 4:01 PM
This revision was landed with ongoing or failed builds.May 5 2024, 8:38 PM
This revision was automatically updated to reflect the committed changes.