Differential D11889

[lib] Include Farcaster username in notifs
ClosedPublic
Actions

Authored by ashoat on May 5 2024, 12:30 PM.

Tags

None

Referenced Files

	F2158261: D11889.id39798.diff
	Mon, Jul 1, 3:26 AM

	Unknown Object (File)
	Fri, Jun 28, 11:44 PM

	Unknown Object (File)
	Fri, Jun 28, 2:43 PM

	Unknown Object (File)
	Tue, Jun 25, 5:18 PM

	Unknown Object (File)
	Mon, Jun 24, 10:42 AM

	Unknown Object (File)
	Thu, Jun 20, 7:44 PM

	Unknown Object (File)
	Thu, Jun 20, 2:33 PM

	Unknown Object (File)
	Thu, Jun 13, 3:31 AM

View All 26 Files

Subscribers

Details

Reviewers

Commits

rCOMMe9af205e4edc: [lib] Include Farcaster username in notifs

Summary

This makes sure that when somebody's Farcaster friend signs up for Comm, they get a notif with their Farcaster username and Comm username.

Depends on D11888

Test Plan

I tested notifs generated on the keyserver and delivered to an Android device, and confirmed that they resolved Farcaster usernames properly

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.May 5 2024, 12:30 PM

Herald added a subscriber: tomek. · View Herald TranscriptMay 5 2024, 12:30 PM

ashoat added a child revision: D11890: [keyserver] Automatically make Farcaster friends Comm friends.May 5 2024, 12:31 PM

Harbormaster completed remote builds in B28672: Diff 39798.May 5 2024, 1:24 PM

ashoat requested review of this revision.May 5 2024, 1:24 PM

ginsu accepted this revision.May 5 2024, 4:35 PM

This revision is now accepted and ready to land.May 5 2024, 4:35 PM

Closed by commit rCOMMe9af205e4edc: [lib] Include Farcaster username in notifs (authored by ashoat). · Explain WhyMay 5 2024, 8:41 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMe9af205e4edc: [lib] Include Farcaster username in notifs.

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

update-relationship-message-spec.js

20 lines

Diff 39798

lib/shared/messages/update-relationship-message-spec.js

Loading...