Page MenuHomePhabricator
Differential D11875

[lib] Rename Neynar types
ClosedPublic
Actions

Authored by ashoat on May 5 2024, 12:09 PM.
Tags
None
Referenced Files
F2138539: D11875.diff
Fri, Jun 28, 11:11 PM
Unknown Object (File)
Tue, Jun 25, 4:25 AM
Unknown Object (File)
Fri, Jun 21, 1:08 PM
Unknown Object (File)
Thu, Jun 20, 8:47 PM
Unknown Object (File)
Thu, Jun 20, 8:09 PM
Unknown Object (File)
Thu, Jun 20, 4:38 PM
Unknown Object (File)
Wed, Jun 19, 7:16 AM
Unknown Object (File)
Fri, Jun 14, 2:46 AM
View All 30 Files
Subscribers
tomek

Details

Reviewers
ginsu
Commits
rCOMM6525da5733ca: [lib] Rename Neynar types
Summary

We are using FarcasterUser as a type name elsewhere in the codebase, and I'm about to introduce a query that will return users from Neynar but without the ViewerContext.

Figured these names would be less ambiguous, but open to other ideas.

Depends on D11874

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.May 5 2024, 12:09 PM
Herald added a subscriber: tomek. · View Herald TranscriptMay 5 2024, 12:09 PM
ashoat added a child revision: D11876: [lib] Introduce NeynarClient.getFarcasterUsernames and FCCache.May 5 2024, 12:11 PM
Harbormaster completed remote builds in B28658: Diff 39784.May 5 2024, 12:26 PM
ashoat requested review of this revision.May 5 2024, 12:26 PM
ginsu added a comment.May 5 2024, 4:01 PM

Figured these names would be less ambiguous, but open to other ideas.

These names make sense to me

ginsu accepted this revision.May 5 2024, 4:01 PM
This revision is now accepted and ready to land.May 5 2024, 4:01 PM
ashoat updated this revision to Diff 39809.May 5 2024, 8:27 PM

Rebase

This revision was landed with ongoing or failed builds.May 5 2024, 8:38 PM
Closed by commit rCOMM6525da5733ca: [lib] Rename Neynar types (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM6525da5733ca: [lib] Rename Neynar types.
Harbormaster completed remote builds in B28677: Diff 39809.May 5 2024, 8:44 PM

Revision Contents
Changeset List

PathSize
lib/
types/
4 lines
utils/
16 lines
native/
community-settings/
tag-farcaster-channel/
6 lines

Diff 39809

View Options

lib/types/farcaster-types.js

Loading...
View Options

lib/utils/neynar-client.js

Loading...
View Options

native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js

Loading...