Page MenuHomePhabricator
Differential D11876

[lib] Introduce NeynarClient.getFarcasterUsernames and FCCache
ClosedPublic
Actions

Authored by ashoat on May 5 2024, 12:11 PM.
Tags
None
Referenced Files
F3518976: D11876.id39785.diff
Sun, Dec 22, 9:10 PM
F3518579: D11876.id39810.diff
Sun, Dec 22, 8:25 PM
Unknown Object (File)
Nov 11 2024, 7:32 AM
Unknown Object (File)
Nov 11 2024, 5:58 AM
Unknown Object (File)
Nov 11 2024, 2:59 AM
Unknown Object (File)
Nov 11 2024, 2:12 AM
Unknown Object (File)
Nov 10 2024, 6:21 PM
Unknown Object (File)
Oct 26 2024, 6:16 AM
View All 69 Files
Subscribers
tomek

Details

Reviewers
ginsu
Commits
rCOMM793f26bcb99c: [lib] Introduce NeynarClient.getFarcasterUsernames and FCCache
Summary

FCCache is modeled after ENSCache, as it serves a similar purpose: caching the results of lookups.

Depends on D11875

Test Plan

I tested this in combination with later diffs on both keyserver and web:

  1. For keyserver, I tested that Farcaster usernames worked in notifs
  2. For web, I tested that Farcaster usernames were resolved in robotext

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.May 5 2024, 12:11 PM
Herald added a subscriber: tomek. · View Herald TranscriptMay 5 2024, 12:11 PM
ashoat added a child revision: D11877: [lib] Introduce getFCNames.May 5 2024, 12:12 PM
Harbormaster completed remote builds in B28659: Diff 39785.May 5 2024, 12:26 PM
ashoat requested review of this revision.May 5 2024, 12:26 PM
ginsu accepted this revision.May 5 2024, 4:07 PM
This revision is now accepted and ready to land.May 5 2024, 4:07 PM
ginsu added a comment.May 5 2024, 6:12 PM

Now that D11865 is landed, there will most likely be merge conflicts with neynar-client.js

ashoat updated this revision to Diff 39810.May 5 2024, 8:28 PM

Rebase

ashoat added a comment.May 5 2024, 8:39 PM

Thanks for the heads-up

This revision was landed with ongoing or failed builds.May 5 2024, 8:40 PM
Closed by commit rCOMM793f26bcb99c: [lib] Introduce NeynarClient.getFarcasterUsernames and FCCache (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM793f26bcb99c: [lib] Introduce NeynarClient.getFarcasterUsernames and FCCache.
Harbormaster completed remote builds in B28678: Diff 39810.May 5 2024, 8:44 PM

Revision Contents
Changeset List

PathSize
lib/
components/
3 lines
types/
10 lines
utils/
152 lines
46 lines

Diff 39815

View Options

lib/components/neynar-client-provider.react.js

Loading...
View Options

lib/types/farcaster-types.js

Loading...
View Options

lib/utils/fc-cache.js

Loading...
View Options

lib/utils/neynar-client.js

Loading...