Page MenuHomePhabricator

[native] handler that just logs out if missing CSAT and no password
ClosedPublic

Authored by varun on May 6 2024, 7:20 AM.
Tags
None
Referenced Files
F3156816: D11906.diff
Tue, Nov 5, 5:37 PM
Unknown Object (File)
Tue, Oct 22, 2:16 PM
Unknown Object (File)
Tue, Oct 22, 1:15 PM
Unknown Object (File)
Tue, Oct 22, 8:35 AM
Unknown Object (File)
Tue, Oct 22, 8:35 AM
Unknown Object (File)
Oct 2 2024, 9:32 PM
Unknown Object (File)
Oct 2 2024, 1:35 AM
Unknown Object (File)
Oct 1 2024, 6:58 AM
Subscribers
None

Details

Summary

this is similar to the LogOutIfMissingCSATHandler but we only log out wallet users since we can't auth in the background for them

Test Plan

as a wallet user on native, with usingCommServicesAccessToken set to true, i cleared the CSAT from redux and confirmed that i was logged out

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun requested review of this revision.May 6 2024, 7:36 AM
ashoat added inline comments.
native/components/background-identity-login-handler.react.js
14

Are we going with this name because this component will also handle automatically logging users in?

33

Slightly different name here than on web. Did you go with this because it's shorter?

34

This appears to be copy-pasted from web. Should we consider factoring it out, or do you think it's fine to copy-paste?

This revision is now accepted and ready to land.May 6 2024, 11:56 AM
native/components/background-identity-login-handler.react.js
14

yeah. should have the diff up soon that adds the auto login logic to this component

33

Yeah, in the alert it looked better with less text

34

i can factor it out before landing