Paths

Table of Contentst

-
landing/
-
siwe.react.js
-
lib/utils/
-
utils/
-
wagmi-utils.js

Differential D11979

[landing] Add support for Coinbase Wallet on mobile
ClosedPublic
Actions

Authored by ashoat on May 9 2024, 11:48 AM.

Details

Reviewers

ginsu

Commits

rCOMM4295f96d633d: [landing] Add support for Coinbase Wallet on mobile

Summary

Following D11949 upgrading us to RainbowKit 2.0.7, Coinbase Wallet now works on mobile!

Test Plan

I tested this in production using the iOS app

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/coinbasewallet

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.May 9 2024, 11:48 AM

Herald added a subscriber: tomek. · View Herald TranscriptMay 9 2024, 11:48 AM

Harbormaster completed remote builds in B28818: Diff 40033.May 9 2024, 12:05 PM

ashoat requested review of this revision.May 9 2024, 12:05 PM

ginsu accepted this revision.May 9 2024, 12:06 PM

This revision is now accepted and ready to land.May 9 2024, 12:06 PM

Show Coinbase Wallet before WalletConnect
Address ENG-8074 by passing ssr parameter to Wagmi. Tested this locally

ashoat added inline comments.May 9 2024, 12:38 PM

lib/utils/wagmi-utils.js
58	Got this solution from here. Tested it locally to confirm it solves ENG-8074

This revision was landed with ongoing or failed builds.May 9 2024, 12:39 PM

Closed by commit rCOMM4295f96d633d: [landing] Add support for Coinbase Wallet on mobile (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM4295f96d633d: [landing] Add support for Coinbase Wallet on mobile.

Harbormaster completed remote builds in B28819: Diff 40034.May 9 2024, 12:55 PM

Revision Contents
Changeset List

Path

Size

landing/

siwe.react.js

7 lines

lib/

utils/

wagmi-utils.js

1 line

Diff 40034

View Options

landing/siwe.react.js