Differential D12021

[keyserver][nix] remove dbType from db-config.js
ClosedPublic
Actions

Authored by will on May 13 2024, 3:28 PM.

Details

Reviewers

ashoat

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rCOMM508243212382: [keyserver][nix] remove dbType from db-config.js

Summary

This removes the usage of dbType from keyserver's db_config.js file. This is no longer necessary and we plan on upgrading from mariadb10.8 to 10.11.

There is a warning that we're supplying dbType as a mariadb configuration option that doesn't exist (as db-config.js now contains a field we don't use), but looks like devs can just manually remove dbType to remove this warning after this is landed

Test Plan

Ran keyserver after removing dbType and ensured it was working with iOS simulator

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

will created this revision.May 13 2024, 3:28 PM

Owners added a reviewer: Restricted Owners Package.May 13 2024, 3:28 PM

Herald added a subscriber: tomek. · View Herald TranscriptMay 13 2024, 3:28 PM

will added a child revision: D12022: [nix] upgrade mariadb from 10.8 to 10.11.May 13 2024, 3:39 PM

will edited the summary of this revision. (Show Details)May 13 2024, 3:41 PM

will edited the test plan for this revision. (Show Details)

will edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B28877: Diff 40136.May 13 2024, 3:44 PM

will requested review of this revision.May 13 2024, 3:44 PM

Let's remove the no-longer-useful spreads

keyserver/src/database/database.js
25 ↗	(On Diff #40136)	There's no point to the spread on assignment here. This syntax is only useful if you're separating something else out
keyserver/src/database/db-config.js
33 ↗	(On Diff #40136)	Don't need this new space imo