Page MenuHomePhabricator
Differential D12634

Bring badgeOnly property to Android notifs
ClosedPublic
Actions

Authored by marcin on Jul 2 2024, 2:36 AM.
Tags
None
Referenced Files
F2897650: D12634.diff
Sat, Oct 5, 12:07 AM
Unknown Object (File)
Wed, Sep 11, 5:58 PM
Unknown Object (File)
Tue, Sep 10, 3:16 PM
Unknown Object (File)
Thu, Sep 5, 7:26 PM
Unknown Object (File)
Thu, Sep 5, 7:26 PM
Unknown Object (File)
Thu, Sep 5, 7:26 PM
Unknown Object (File)
Thu, Sep 5, 7:26 PM
Unknown Object (File)
Aug 22 2024, 12:39 AM
View All 43 Files
Subscribers
ashoat

Details

Reviewers
tomek
Commits
rCOMMeac27d1c8c6d: Bring badgeOnly property to Android notifs
Summary

This differential solves urgent issue: https://linear.app/comm/issue/ENG-8620/badge-only-notifs-are-broken-on-android-in-production. No need to change on client. If the Andorid client sees badgeOnly:'1' they will return early without displaying notification.

Test Plan
  1. Build Android app.
  2. Mark a thread as badge only in settings.
  3. Send notif from this thread. Ensure the notif is delivered.
  4. Apply this diff.
  5. Send notif from this thread. Ensure that the notifs is not delivered.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.Jul 2 2024, 2:36 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJul 2 2024, 2:36 AM
tomek published this revision for review.Jul 2 2024, 2:38 AM
tomek accepted this revision.
This revision is now accepted and ready to land.Jul 2 2024, 2:38 AM
This revision was landed with ongoing or failed builds.Jul 2 2024, 2:52 AM
Closed by commit rCOMMeac27d1c8c6d: Bring badgeOnly property to Android notifs (authored by marcin). · Explain Why
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMeac27d1c8c6d: Bring badgeOnly property to Android notifs.
Harbormaster completed remote builds in B30043: Diff 41873.Jul 2 2024, 2:52 AM

Revision Contents
Changeset List

PathSize
keyserver/
src/
push/
20 lines

Diff 41875

View Options

keyserver/src/push/send.js

Loading...