Page MenuHomePhabricator
Differential D12815

[terraform] landing terraform config
ClosedPublic
Actions

Authored by will on Jul 19 2024, 8:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 5, 3:56 AM
Unknown Object (File)
Sat, Apr 5, 2:11 AM
Unknown Object (File)
Fri, Apr 4, 10:59 PM
Unknown Object (File)
Thu, Apr 3, 8:07 PM
Unknown Object (File)
Fri, Mar 28, 7:32 PM
Unknown Object (File)
Mon, Mar 17, 1:15 AM
Unknown Object (File)
Feb 28 2025, 1:18 AM
Unknown Object (File)
Feb 28 2025, 1:18 AM
View All 64 Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMM15bcdda59137: [terraform] landing terraform config
Summary

This is the terraform configuration for landing

Depends on D12813

Test Plan

Will not land until confirmed landing page is accessible at the domain I've tied it to

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
services/
terraform/
self-host/
169 lines

Diff 42569

View Options

services/terraform/self-host/landing.tf

Show First 20 Lines • Show All 396 Lines • ▼ Show 20 Lines async ensureAndroidPushNotifsEnabled() {
let [hasPermission] = permissionPromisesResult; let [hasPermission] = permissionPromisesResult;
const [, canRequestPermission] = permissionPromisesResult; const [, canRequestPermission] = permissionPromisesResult;
if (!hasPermission && canRequestPermission) { if (!hasPermission && canRequestPermission) {
const permissionResponse = await (async () => { const permissionResponse = await (async () => {
// We issue a call to sleep to match iOS behavior where prompt // We issue a call to sleep to match iOS behavior where prompt
// doesn't appear immediately but after logged-out modal disappears // doesn't appear immediately but after logged-out modal disappears
await sleep(10); await sleep(10);
await this.requestAndroidNotificationsPermission(); return await this.requestAndroidNotificationsPermission();
marcinUnsubmitted
Not Done
Inline Actions

We definitely should return something from this lambda since otherwise it is useless to assign it to variable.

When we find we don't have Android notif permissions, we ignore the result of requestAndroidNotificationsPermission. It seems like that would cause us to fail to register notif permissions on Android.

If we find that we don't have permissions then just calling await this.requestAndroidNotificationsPermission(); would result in a prompt asking for notifications permissions. However if the user grants those permissions then hasPermissions is still falsy (since promise returned nothing), so deviceToken will be set to null. Nevertheless permissions are actually granted byt the OS, so the state on the device and keyserver would heal itself on next render.

This differential fixes this case so that if user grants permissions correct state is achieved immediately without need for additional re-render to heal the state.

marcin: We definitely should return something from this lambda since otherwise it is useless to assign…
})(); })();
hasPermission = permissionResponse; hasPermission = permissionResponse;
} }
if (!hasPermission) { if (!hasPermission) {
this.failedToRegisterPushPermissionsAndroid(!canRequestPermission); this.failedToRegisterPushPermissionsAndroid(!canRequestPermission);
return; return;
} }
▲ Show 20 Lines • Show All 328 Lines • Show Last 20 Lines