Differential D12950

[desktop] add cross-env dependency and use it to set environment variables in desktop/package.json
ClosedPublic
Actions

Authored by varun on Jul 30 2024, 3:34 PM.

Details

Reviewers

ashoat

Commits

rCOMM130a1bc44270: [desktop] add cross-env dependency and use it to set environment variables in…

Summary

windows ignores ENV=dev unless we use cross-env, which sets the environment variable in a windows-compatible way

Test Plan

when I console log process.env.ENV now, i see "dev" in my terminal. before this change, it was undefined

Diff Detail

Repository

rCOMM Comm

Branch

windows (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Jul 30 2024, 3:34 PM

Herald added a subscriber: tomek. · View Herald TranscriptJul 30 2024, 3:34 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 30 2024, 3:59 PM

Harbormaster failed remote builds in B30822: Diff 42975!

fix CI

Harbormaster completed remote builds in B30825: Diff 42978.Jul 30 2024, 7:14 PM

varun requested review of this revision.Jul 30 2024, 7:14 PM

Looks legit

This revision is now accepted and ready to land.Jul 30 2024, 10:49 PM

Closed by commit rCOMM130a1bc44270: [desktop] add cross-env dependency and use it to set environment variables in… (authored by varun). · Explain WhyAug 6 2024, 9:12 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM130a1bc44270: [desktop] add cross-env dependency and use it to set environment variables in….

Revision Contents
Changeset List

Path

Size

desktop/

package.json

13 lines

yarn.lock

7 lines

Diff 42978

View Options

desktop/package.json