lib/shared/dm-ops/process-dm-ops.js
58–62	We could also consider modifying `dispatchWithMessageSource` to take `metadata` as an optional parameter, which would allow for simplifying the code here.

This revision is now accepted and ready to land.Aug 7 2024, 2:50 AM

Do we need DMOpsQueueHandler to pass in MessageSourceMetadata as well?

address review

inline

Harbormaster failed remote builds in B31000: Diff 43246!Aug 8 2024, 1:47 AM

Harbormaster failed remote builds in B31001: Diff 43247!Aug 8 2024, 1:50 AM

In D13007#367909, @ashoat wrote:

Do we need DMOpsQueueHandler to pass in MessageSourceMetadata as well?

No, we decided to pass in MessageSourceMetadata on queueDMOpsActionType- and as a result message will be confirmed as processed after queueing up this DM action.

This should be safe because we persist queued operations, and since there are pruned there is still a risk that operation will never be applied to the store (so the risk is still there, and I think was considered when implementing queue). We can update the code to send confirmation after processing or pruning (but this will require changing pruning logic).

This revision was landed with ongoing or failed builds.Aug 8 2024, 2:33 AM

Closed by commit rCOMM09df98f2c578: [lib] fix processing DM ops by adding `MessageSourceMetadata` param (authored by kamil). · Explain Why

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM09df98f2c578: [lib] fix processing DM ops by adding `MessageSourceMetadata` param.