Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- land-fixes
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/shared/dm-ops/process-dm-ops.js | ||
|---|---|---|
| 58–62 ↗ | (On Diff #43216) | We could also consider modifying dispatchWithMessageSource to take metadata as an optional parameter, which would allow for simplifying the code here. |
Comment Actions
No, we decided to pass in MessageSourceMetadata on queueDMOpsActionType- and as a result message will be confirmed as processed after queueing up this DM action.
This should be safe because we persist queued operations, and since there are pruned there is still a risk that operation will never be applied to the store (so the risk is still there, and I think was considered when implementing queue). We can update the code to send confirmation after processing or pruning (but this will require changing pruning logic).