[lib] fix usage of `userID` in DMOp messages
ClosedPublic
Actions

Authored by kamil on Aug 7 2024, 1:23 AM.

Details

Reviewers

ashoat
tomek

Commits

rCOMMce71bd6e3ef1: [lib] fix usage of `userID` in DMOp messages

Summary

ENG-8965.

Test Plan

Described in ENG-8964

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Aug 7 2024, 1:23 AM

kamil held this revision as a draft.

kamil added a child revision: D13006: [lib] fix generating DM messages to peers.Aug 7 2024, 1:28 AM

kamil published this revision for review.Aug 7 2024, 1:39 AM

Harbormaster completed remote builds in B30975: Diff 43214.Aug 7 2024, 1:40 AM

tomek accepted this revision.Aug 7 2024, 2:37 AM

tomek added inline comments.

lib/shared/dm-ops/dm-op-utils.js
67–73 ↗	(On Diff #43214)	How about renaming these and making the names consistent?

This revision is now accepted and ready to land.Aug 7 2024, 2:37 AM

address review

Harbormaster failed remote builds in B30999: Diff 43245!Aug 8 2024, 1:46 AM

This revision was landed with ongoing or failed builds.Aug 8 2024, 2:33 AM

Closed by commit rCOMMce71bd6e3ef1: [lib] fix usage of `userID` in DMOp messages (authored by kamil). · Explain Why

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMce71bd6e3ef1: [lib] fix usage of `userID` in DMOp messages.

Revision Contents
Changeset List

Path

Size

lib/

shared/

dm-ops/

dm-op-utils.js

41 lines

tunnelbroker/

peer-to-peer-context.js

7 lines

Diff 43248

View Options

lib/shared/dm-ops/dm-op-utils.js