Page MenuHomePhabricator

[native] Fix VideoPlaybackModal for encrypted keyserver-hosted media
ClosedPublic

Authored by ashoat on Aug 9 2024, 9:31 PM.
Tags
None
Referenced Files
F3004211: D13039.id43291.diff
Fri, Oct 18, 1:27 PM
F3004195: D13039.diff
Fri, Oct 18, 1:21 PM
Unknown Object (File)
Sep 18 2024, 12:58 AM
Unknown Object (File)
Sep 16 2024, 1:08 AM
Unknown Object (File)
Sep 14 2024, 11:47 PM
Unknown Object (File)
Sep 14 2024, 11:47 PM
Unknown Object (File)
Sep 14 2024, 11:46 PM
Unknown Object (File)
Sep 14 2024, 11:44 PM
Subscribers

Details

Summary

Encrypted keyserver-hosted encrypted media works on web, but on native it looks like only blob-hosted encrypted media works.

I think this work was missed. I found we're using encryptedMediaBlobURI on web (and elsewhere on native), so I integrated it here and it looks like it did the trick.

Test Plan

Prior to this, when opening keyserver-hosted encrypted media, the app would basically freeze... it would be stuck loading the content, but it wouldn't show anything.

After this diff, I confirmed that keyserver-hosted media loads correctly, and can be viewed.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat requested review of this revision.Aug 9 2024, 9:48 PM
native/media/video-playback-modal.react.js
96–99 ↗(On Diff #43291)

Snuck in this rename to match conventions

This revision is now accepted and ready to land.Aug 11 2024, 1:24 AM