[keyserver] Specify MariaDB port in backups code
ClosedPublic
Actions

Authored by ashoat on Aug 21 2024, 5:32 PM.

Details

Reviewers

will

Commits

rCOMM0e8d5871fcc8: [keyserver] Specify MariaDB port in backups code

Summary

In D12336 we added support to DBConfig for a port, but we forgot to update the backups code to specify this port when calling mysqldump.

This addresses at least part of ENG-9077.

Test Plan

Ran this on my keyserver instance running in a Docker container on my personal server and confirmed that it works

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Aug 21 2024, 5:32 PM

Herald added a subscriber: tomek. · View Herald TranscriptAug 21 2024, 5:32 PM

Harbormaster completed remote builds in B31207: Diff 43561.Aug 21 2024, 5:53 PM

ashoat requested review of this revision.Aug 21 2024, 5:53 PM

ashoat added a child revision: D13135: [keyserver] Introduce concept of auxiliary node for running certain cronjobs.Aug 21 2024, 6:00 PM

will accepted this revision.Aug 21 2024, 10:49 PM

This revision is now accepted and ready to land.Aug 21 2024, 10:49 PM

Closed by commit rCOMM0e8d5871fcc8: [keyserver] Specify MariaDB port in backups code (authored by ashoat). · Explain WhyAug 22 2024, 12:05 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM0e8d5871fcc8: [keyserver] Specify MariaDB port in backups code.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

cron/

backups.js

40 lines

Diff 43563

View Options

keyserver/src/cron/backups.js

[keyserver] Specify MariaDB port in backups codeClosedPublicActions