Page MenuHomePhabricator

One check for minimum code version supporting e2ee notifs
ClosedPublic

Authored by marcin on Sep 6 2024, 10:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 12, 6:49 PM
Unknown Object (File)
Tue, Mar 11, 9:49 AM
Unknown Object (File)
Thu, Mar 6, 4:41 AM
Unknown Object (File)
Sat, Mar 1, 10:58 AM
Unknown Object (File)
Wed, Feb 26, 1:01 PM
Unknown Object (File)
Wed, Feb 26, 11:36 AM
Unknown Object (File)
Fri, Feb 21, 9:16 PM
Unknown Object (File)
Sat, Feb 15, 9:28 PM
Subscribers

Details

Summary

This differential ensures that e2ee notifs are sent to devices supporting code version that will be determined during staff e2ee dm's release

Test Plan

Ensure that e2ee notifs work if and only if FUTURE_CODE_VERSION is 0

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-e2ee-notif-version-check
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

This revision is now accepted and ready to land.Sep 11 2024, 2:02 AM

More robust check. If the device doesn't support E2EE notifs we won't even try to create a notifs session with it.

Re-requesting review as this new check is much better - we won't try to create a session nor process any data with device that does not have sufficient code version.

This revision is now accepted and ready to land.Sep 11 2024, 7:41 AM