Page MenuHomePhabricator
Differential D13261

One check for minimum code version supporting e2ee notifs
ClosedPublic
Actions

Authored by marcin on Sep 6 2024, 10:02 AM.
Tags
None
Referenced Files
F2999317: D13261.id43942.diff
Thu, Oct 17, 10:20 PM
Unknown Object (File)
Mon, Oct 14, 2:28 PM
Unknown Object (File)
Mon, Oct 14, 4:47 AM
Unknown Object (File)
Sun, Oct 13, 11:19 PM
Unknown Object (File)
Sun, Oct 13, 9:16 AM
Unknown Object (File)
Fri, Oct 11, 2:05 AM
Unknown Object (File)
Wed, Oct 9, 4:20 AM
Unknown Object (File)
Mon, Oct 7, 7:31 PM
View All 37 Files
Subscribers
ashoat

Details

Reviewers
tomek
Commits
rCOMM29f2689035ef: One check for minimum code version supporting e2ee notifs
Summary

This differential ensures that e2ee notifs are sent to devices supporting code version that will be determined during staff e2ee dm's release

Test Plan

Ensure that e2ee notifs work if and only if FUTURE_CODE_VERSION is 0

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-e2ee-notif-version-check
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Sep 6 2024, 10:02 AM
Herald added a subscriber: ashoat. · View Herald TranscriptSep 6 2024, 10:02 AM
Harbormaster completed remote builds in B31464: Diff 43942.Sep 6 2024, 10:23 AM
marcin requested review of this revision.Sep 6 2024, 10:23 AM
tomek accepted this revision.Sep 11 2024, 2:02 AM
This revision is now accepted and ready to land.Sep 11 2024, 2:02 AM
marcin updated this revision to Diff 44039.Sep 11 2024, 6:50 AM

More robust check. If the device doesn't support E2EE notifs we won't even try to create a notifs session with it.

marcin requested review of this revision.Sep 11 2024, 7:00 AM

Re-requesting review as this new check is much better - we won't try to create a session nor process any data with device that does not have sufficient code version.

Harbormaster completed remote builds in B31532: Diff 44039.Sep 11 2024, 7:08 AM
tomek accepted this revision.Sep 11 2024, 7:41 AM
This revision is now accepted and ready to land.Sep 11 2024, 7:41 AM
marcin updated this revision to Diff 44067.Sep 12 2024, 2:17 AM

rebase before landing

Harbormaster completed remote builds in B31553: Diff 44067.Sep 12 2024, 2:34 AM
Closed by commit rCOMM29f2689035ef: One check for minimum code version supporting e2ee notifs (authored by marcin). · Explain WhySep 12 2024, 2:48 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM29f2689035ef: One check for minimum code version supporting e2ee notifs.

Revision Contents
Changeset List

PathSize
lib/
push/
17 lines
16 lines
53 lines

Diff 44067

View Options

lib/push/android-notif-creators.js

Loading...
View Options

lib/push/apns-notif-creators.js

Loading...
View Options

lib/push/send-utils.js

Loading...