Page MenuHomePhabricator

[lib] don't process persisted inbound messages without `viewerID`
ClosedPublic

Authored by kamil on Sep 24 2024, 3:56 AM.
Tags
None
Referenced Files
F3299786: D13445.id44535.diff
Sun, Nov 17, 3:36 PM
F3299764: D13445.id44479.diff
Sun, Nov 17, 3:26 PM
F3299524: D13445.diff
Sun, Nov 17, 1:00 PM
Unknown Object (File)
Fri, Nov 1, 2:14 PM
Unknown Object (File)
Wed, Oct 30, 11:09 PM
Unknown Object (File)
Oct 14 2024, 12:43 PM
Unknown Object (File)
Oct 14 2024, 12:43 PM
Unknown Object (File)
Oct 14 2024, 12:43 PM
Subscribers

Details

Summary

ENG-9381.

I had some InboundP2PMessage's in the store, and I discovered that they're causing ignored DMOperation because logged out.
This is a race condition because this component can run before getting loggedInUserInfo in getInitialReduxState and useProcessDMOperation was called without viewerID.

This fixes the issue.

This is also safe for messages not from DB but received from Tunnelbroker, we're going to establish a socket connection only when viewerID is defined anyway.

Test Plan

Seeing the messages processed.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable