Page MenuHomePhabricator
Differential D13496

[lib] Get rid of effect in useUpdateRelationships
ClosedPublic
Actions

Authored by ashoat on Sep 26 2024, 3:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 4:18 PM
Unknown Object (File)
Sat, Nov 9, 3:51 AM
Unknown Object (File)
Fri, Nov 8, 3:01 AM
Unknown Object (File)
Fri, Nov 8, 3:01 AM
Unknown Object (File)
Fri, Nov 8, 3:01 AM
Unknown Object (File)
Fri, Nov 1, 4:22 PM
Unknown Object (File)
Fri, Nov 1, 5:36 AM
Unknown Object (File)
Thu, Oct 31, 3:00 AM
View All 39 Files
Subscribers
tomek

Details

Reviewers
kamil
Commits
rCOMMfc060e17cacd: [lib] Get rid of effect in useUpdateRelationships
Summary

Kamil's work in D13486 lets us greatly simplify this code.

Depends on D13489

Test Plan

I tested with two devices: one iOS simulator, one physical Android. I followed the steps below twice, with iOS / Android alternating roles:

  1. User A and user B create accounts
  2. User B backgrounds the app
  3. User A searches for user B and sends them a friend request
  4. Confirm notifs are received. Confirm chat shows up as DM in UI
  5. User A backgrounds the app
  6. User B accepts the friend request
  7. Confirm notifs received

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/refactor
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Sep 26 2024, 3:18 PM
Herald added a subscriber: tomek. · View Herald TranscriptSep 26 2024, 3:18 PM
ashoat mentioned this in D13486: [lib] implement fetching missing peers when generating P2P messages.Sep 26 2024, 3:20 PM
Harbormaster completed remote builds in B31890: Diff 44614.Sep 26 2024, 3:35 PM
ashoat requested review of this revision.Sep 26 2024, 3:35 PM
kamil mentioned this in D13488: [lib] rename `userSupportsThickThreads` -> `userHasDeviceList`.Sep 30 2024, 4:54 AM
kamil accepted this revision.Sep 30 2024, 5:33 AM
This revision is now accepted and ready to land.Sep 30 2024, 5:33 AM
ashoat updated this revision to Diff 44684.Sep 30 2024, 5:52 AM

Rebase

Harbormaster completed remote builds in B31933: Diff 44684.Sep 30 2024, 6:09 AM
Closed by commit rCOMMfc060e17cacd: [lib] Get rid of effect in useUpdateRelationships (authored by ashoat). · Explain WhySep 30 2024, 6:10 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMfc060e17cacd: [lib] Get rid of effect in useUpdateRelationships.
ashoat mentioned this in D13521: [lib] Allow multiple simultaneous calls to useUpdateRelationships from a single component.Sep 30 2024, 8:43 AM
ashoat mentioned this in rCOMM001e72586928: [lib] Allow multiple simultaneous calls to useUpdateRelationships from a single….Sep 30 2024, 5:03 PM
ashoat mentioned this in D13698: [lib] Use the actions queue in the peer to peer context.Oct 11 2024, 11:23 AM

Revision Contents
Changeset List

PathSize
lib/
hooks/
156 lines

Diff 44684

View Options

lib/hooks/relationship-hooks.js

Loading...