Page MenuHomePhabricator

[lib][keyserver][native] Stop sending passwords to authoritative keyserver on registration
ClosedPublic

Authored by ashoat on Oct 28 2024, 1:45 PM.
Tags
None
Referenced Files
F3387169: D13800.id45429.diff
Fri, Nov 29, 8:01 AM
F3387116: D13800.id45411.diff
Fri, Nov 29, 7:43 AM
Unknown Object (File)
Sun, Nov 24, 8:41 PM
Unknown Object (File)
Wed, Nov 20, 1:35 PM
Unknown Object (File)
Tue, Nov 12, 9:03 PM
Unknown Object (File)
Mon, Nov 11, 5:06 AM
Unknown Object (File)
Sun, Nov 10, 10:12 PM
Unknown Object (File)
Wed, Nov 6, 2:03 AM
Subscribers

Details

Summary

Context for why we want to revert this is in D12641. Linear task: ENG-8698

This reverts commit 51a51ba64cc988a189e843d1165a8c77ecad578f.

It's not a perfect revert, since we need to preserve the field in keyserverAuthRequestInputValidator for old clients.

To keep the field in the validator, I had to split KeyserverAuthRequest into two types, one for keyserver and one for clients.

Test Plan

I ran through the registration flow in my local environment and made sure it still works. I confirmed that the hash column in the users table in MariaDB is NULL

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/revert
Lint
No Lint Coverage
Unit
No Test Coverage