Page MenuHomePhabricator

[lib][keyserver][native] Stop sending passwords to authoritative keyserver on registration
ClosedPublic

Authored by ashoat on Mon, Oct 28, 1:45 PM.
Tags
None
Referenced Files
F3103225: D13800.id45429.diff
Wed, Oct 30, 12:21 PM
F3102392: D13800.diff
Wed, Oct 30, 10:35 AM
Unknown Object (File)
Mon, Oct 28, 3:01 PM
Unknown Object (File)
Mon, Oct 28, 3:00 PM
Unknown Object (File)
Mon, Oct 28, 3:00 PM
Subscribers

Details

Summary

Context for why we want to revert this is in D12641. Linear task: ENG-8698

This reverts commit 51a51ba64cc988a189e843d1165a8c77ecad578f.

It's not a perfect revert, since we need to preserve the field in keyserverAuthRequestInputValidator for old clients.

To keep the field in the validator, I had to split KeyserverAuthRequest into two types, one for keyserver and one for clients.

Test Plan

I ran through the registration flow in my local environment and made sure it still works. I confirmed that the hash column in the users table in MariaDB is NULL

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable