[services] Fix missing port number in D13881
ClosedPublic
Actions

Authored by ashoat on Nov 5 2024, 6:29 PM.

Details

Reviewers

Commits

rCOMMb0b1ffc3dd72: [services] Fix missing port number in D13881

Summary

On Linear, @varun indicated the the port number could be elided here. Turns out that wasn't true, and we're now seeing issues deploying this update to production. I'm landing this change without review in order to fix production.

Test Plan

Unfortunately, we are testing on prod.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Nov 5 2024, 6:29 PM

Herald added a subscriber: tomek. · View Herald TranscriptNov 5 2024, 6:29 PM

This revision was not accepted when it landed; it landed in state Draft.Nov 5 2024, 6:29 PM

This revision was landed with ongoing or failed builds.

Closed by commit rCOMMb0b1ffc3dd72: [services] Fix missing port number in D13881. · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMb0b1ffc3dd72: [services] Fix missing port number in D13881.

ashoat mentioned this in D13881: [services] Allow browsers to access prod identity from comm.software.Nov 5 2024, 6:30 PM

Doesn't look like this worked, unfortunately

ashoat added a reverting change: rCOMMee0702380b37: Revert "[services] Fix missing port number in D13881".Nov 5 2024, 6:37 PM

Harbormaster completed remote builds in B32552: Diff 45624.Nov 5 2024, 6:46 PM

Revision Contents
Changeset List

Path

Size

services/

terraform/

remote/

service_identity.tf

2 lines

Diff 45624

View Options

services/terraform/remote/service_identity.tf

[services] Fix missing port number in D13881ClosedPublicActions