We probably shouldn't early exit if this flag is unset.
https://linear.app/comm/issue/ENG-11297/unread-status-is-not-synced-between-farcaster-and-comm-apps
Details
Details
- Reviewers
kamil - Commits
- rCOMMe45fd743044f: [lib] Record the unread thread activity
Check on both native and web: enter an unread Farcaster thread and see if the status is updated on the other Comm client and on Farcaster.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/handlers/non-keyserver-activity-handler.js | ||
|---|---|---|
| 81–82 | The logic regarding activity updates is quite complicated, and probably @kamil understands it better. For me it seems like when UpdatedByActivityHandlerOnly isn't set, we shouldn't early return, as this flag only means that there are some other places that could be also updating the state, not that they are the only places. | |