Paths

Table of Contentst

Differential D15433

[native] Sync Farcaster threads after registration
ClosedPublic
Actions

Authored by tomek on Oct 8 2025, 5:57 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

kamil
ashoat

Commits

rCOMM7bb99e0d9065: [native] Sync Farcaster threads after registration

Summary

Set a flag if the user connected their account

https://linear.app/comm/issue/ENG-11393/farcaster-conversations-are-gone-after-registration-using-siwf-and

Test Plan

Register a new account and see if the threads were fetched

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Oct 8 2025, 5:57 PM

Herald added a subscriber: ashoat. · View Herald TranscriptOct 8 2025, 5:57 PM

Just wondering, isn't the default false already?

Harbormaster completed remote builds in B35889: Diff 50563.Oct 8 2025, 6:36 PM

tomek requested review of this revision.Oct 8 2025, 6:36 PM

In D15433#424387, @ashoat wrote:

Just wondering, isn't the default false already?

This is based on the syncedMetadataStore where we have the third state - undefined. I'm not exactly sure why, but we're checking if the flag is explicitly === false, which is different from the default undefined. I feel that we could simplify this, but I don't think it is worth prioritizing now.

ashoat accepted this revision.Oct 9 2025, 12:39 PM

This revision is now accepted and ready to land.Oct 9 2025, 12:39 PM

Closed by commit rCOMM7bb99e0d9065: [native] Sync Farcaster threads after registration. · Explain WhyOct 9 2025, 3:02 PM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM7bb99e0d9065: [native] Sync Farcaster threads after registration.

Revision Contents
Changeset List

Path

Size

native/

account/

registration/

registration-terms.react.js

13 lines

Diff 50563

native/account/registration/registration-terms.react.js

Loading...