Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp | ||
|---|---|---|
| 28–33 | I would reference this place in NotificationService.mm and CommNotificationsHandler.java | |
Comment Actions
In the corresponding task, @tomek says he’s not sure this is an improvement. I suspect that’s because of increased code (which translates to maintenance cost) and that fact that doing this as a follow-up with no automated migration means we will probably need to skip shipping the prior builds to production. Based on those concerns I’d probably abandon it, but open to hearing a different perspective.