Differential D15503

[native][web] Introduce a new thread column for pin IDs
ClosedPublic
Actions

Authored by tomek on Oct 22 2025, 2:13 PM.

Details

Reviewers

kamil

Commits

rCOMM54c011c1df3c: [native][web] Introduce a new thread column for pin IDs

Summary

Update the C++ code.

https://linear.app/comm/issue/ENG-11220/handle-message-pinning

Depends on D15502

Test Plan

Tested in combination with the rest of the stack: both on native and web, test if pinning and unpinning works. Also tested if the pins persist app reopens. Checked if the pins are correctly saved on Farcaster.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Oct 22 2025, 2:13 PM

Herald added a subscriber: ashoat. · View Herald TranscriptOct 22 2025, 2:13 PM

Rebase

tomek added a child revision: D15504: [native][web] Improve the pin modals.Oct 22 2025, 2:36 PM

Harbormaster failed remote builds in B35987: Diff 50729!Oct 22 2025, 4:33 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 22 2025, 5:34 PM

Harbormaster failed remote builds in B35993: Diff 50735!

Harbormaster completed remote builds in B35993: Diff 50735.Oct 23 2025, 10:29 AM

tomek requested review of this revision.Oct 23 2025, 10:29 AM

kamil accepted this revision.Oct 23 2025, 1:53 PM

kamil added inline comments.

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
567–577	Why this change?
native/cpp/CommonCpp/DatabaseManagers/SQLiteSchemaMigrations.cpp
865	Updating older migrations is not a good idea

This revision is now accepted and ready to land.Oct 23 2025, 1:53 PM

tomek added inline comments.Oct 23 2025, 2:09 PM

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
567–577	I had some problems while making it all work and making the ordering of the props explicit was one of the things I tried. With this ordering and some other changes, the solution works, but probably reverting this shouldn't break the solution.
native/cpp/CommonCpp/DatabaseManagers/SQLiteSchemaMigrations.cpp
865	Ugh, right

Address review

Tested the migration:

Registered an account with SQLite DB 58
Logged in on a secondary with the migration - the worker logs show that the migration 59 succeeded
Updated the primary - the migration 59 succeeded

Harbormaster completed remote builds in B36012: Diff 50757.Oct 23 2025, 3:55 PM

Closed by commit rCOMM54c011c1df3c: [native][web] Introduce a new thread column for pin IDs. · Explain WhyOct 23 2025, 4:11 PM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM54c011c1df3c: [native][web] Introduce a new thread column for pin IDs.