Differential D15502

[lib] Optimistically update after pinning
ClosedPublic
Actions

Authored by tomek on Oct 22 2025, 2:11 PM.

Details

Reviewers

kamil

Commits

rCOMM23f2914b7e37: [lib] Optimistically update after pinning

Summary

Optimistically update the pins.

https://linear.app/comm/issue/ENG-11220/handle-message-pinning

Depends on D15501

Test Plan

Tested in combination with the rest of the stack: both on native and web, test if pinning and unpinning works. Also tested if the pins persist app reopens. Checked if the pins are correctly saved on Farcaster.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Oct 22 2025, 2:11 PM

Herald added a subscriber: ashoat. · View Herald TranscriptOct 22 2025, 2:11 PM

tomek added a child revision: D15503: [native][web] Introduce a new thread column for pin IDs.Oct 22 2025, 2:13 PM

Rebase

Harbormaster failed remote builds in B35986: Diff 50728!Oct 22 2025, 4:10 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 22 2025, 5:47 PM

Harbormaster failed remote builds in B35992: Diff 50734!

Harbormaster completed remote builds in B35992: Diff 50734.Oct 23 2025, 10:29 AM

tomek requested review of this revision.Oct 23 2025, 10:29 AM

kamil accepted this revision.Oct 23 2025, 1:24 PM

kamil added inline comments.

lib/shared/threads/protocols/farcaster-thread-protocol.js
975 ↗	(On Diff #50734)	If it supports only one at a time, shouldn't this be an empty array?

This revision is now accepted and ready to land.Oct 23 2025, 1:24 PM

tomek added inline comments.Oct 23 2025, 1:30 PM

lib/shared/threads/protocols/farcaster-thread-protocol.js
975 ↗	(On Diff #50734)	It's a protection against an unexpected case where we try to unpin a message that isn't pinned. Maybe if the modal is displayed while another user pins a message, a thing like this could happen.