HomePhabricator
Diffusion Comm 04ae087118c1

[web] gate avatars rendering

Description

[web] gate avatars rendering

Summary:
Added a hard variable called shouldRenderAvatars to gate the avatars rendering work for web. Gating this work will allow me to land all the diffs in this stack without launching avatars. I know this is a big diff; however, when we eventually have avatars in stable condition, I think it will be nice to get rid of this code, so having one diff that shows all the changes that need to be "reverted" is why I decided to make this diff bigger than normal.

Depends on D7276

Test Plan:
Tested all areas that have avatars and made sure that the avatars didn't render when the gate was closed:

When the gate is closed:

Screenshot 2023-04-03 at 5.18.27 AM.png (1×3 px, 1 MB)

When the gate is open:

Screenshot 2023-04-03 at 5.18.19 AM.png (1×3 px, 1 MB)

Reviewers: ashoat, atul

Reviewed By: atul

Subscribers: ashoat, tomek, atul

Differential Revision: https://phab.comm.dev/D7277

Details

Provenance
ginsuAuthored on Apr 4 2023, 11:19 AM
Reviewer
atul
Differential Revision
D7277: [web] gate avatars rendering
Parents
rCOMMbd4639ba9a22: [web] render thread avatars in thread picker modal
Branches
Unknown
Tags
Unknown