HomePhabricator
Diffusion Comm 07375b672901

[Services] Fix blob test build

Description

[Services] Fix blob test build

Summary:
I would like to add the test suites to the CI, but they have to
build first

Also, a big change is building the testsuite by default, however, this is
the common practice, and generally people opt-out of building tests by doing
-DBUILD_TESTING=OFF when they invoke cmake.

https://linear.app/comm/issue/ENG-1788

Test Plan:

nix develop
cd services/blob
rm -rf build && mkdir build && cd build && cmake .. && make -j
ctest # should fail as AWS needs to be configured, but run

# without tests
nix develop
cd services/blob
rm -rf build && mkdir build && cd build && cmake .. -DBUILD_TESTING=OFF && make -j
ctest # should fail to find tests

Reviewers: atul, abosh, varun, max, karol

Reviewed By: atul

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D5116

Details

Provenance
jonAuthored on Sep 12 2022, 12:03 PM
Reviewer
atul
Differential Revision
D5116: [Services] Fix blob test build
Parents
rCOMM2e355ef44e35: [Services] Avoid using GTest in docker
Branches
Unknown
Tags
Unknown