HomePhabricator
Diffusion Comm 078cd822453e

[native] Fix appearance of `TabNavigator` in light mode

Tags
None
Referenced Files
F232317: 85d343.png
Nov 11 2022, 1:08 PM
File Not Attached
F232316: 214ce5.png
Nov 11 2022, 1:08 PM
File Not Attached
Subscribers
None

Description

[native] Fix appearance of TabNavigator in light mode

Summary:
Context: https://linear.app/comm/issue/ENG-2052/re-introduce-light-mode-in-native

The backgroundColor of TabNavigator was previously hardcoded to a dark value that looked fine in dark mode but looked broken in light mode.

This diff sets the backgroundColor to tabBarBackground which will adapt based on the theme.

Test Plan:
Before:

214ce5.png (1×710 px, 303 KB)

After:

85d343.png (1×706 px, 305 KB)

Things look as expected.

Reviewers: tomek, marcin, ginsu, rohan, abosh, varun, O2 Blocking Reviewers, ashoat

Reviewed By: ginsu, O2 Blocking Reviewers, ashoat

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D5611

Details

Provenance
atulAuthored on Nov 10 2022, 5:19 PM
Reviewer
Restricted Owners Package
Differential Revision
D5611: [native] Fix appearance of `TabNavigator` in light mode
Parents
rCOMM10d59f3d5dbb: [native] Fix appearance of Inbox header in light mode
Branches
Unknown
Tags
Unknown