HomePhabricator
Diffusion Comm 08e32f173296

[keyserver] Allow staff to use reserved names for invite links

Description

[keyserver] Allow staff to use reserved names for invite links

Summary:
This addresses the second part of ENG-8263: update the keyserver code to allow staff members to set invite links that are reserved.

Depends on D12242

Test Plan:
Tested invite link flow end-to-end on web by creating an invite link named "music" as a keyserver admin, and then opening it in an Incognito tab as another user, and confirming I am able to join. Before modifying lib/facts/staff.json to include the local keyserver admin, it did not work. Afterwards it did

I was surprised that the staging blob service did not reject my invite link creation, given that I was using a reserved string. This calls into question whether any changes on the blob service are necessary. Will document this on ENG-8302.

Reviewers: tomek

Reviewed By: tomek

Differential Revision: https://phab.comm.dev/D12243

Details

Provenance
ashoatAuthored on May 29 2024, 1:01 PM
Reviewer
tomek
Differential Revision
D12243: [keyserver] Allow staff to use reserved names for invite links
Parents
rCOMM06ee9db140f2: [lib] Allow dash character in invite links
Branches
Unknown
Tags
Unknown