HomePhabricator
Diffusion Comm 09c80b959990

[flow] Add `(killall flow || pkill flow || true)` to `cleaninstall`

Description

[flow] Add (killall flow || pkill flow || true) to cleaninstall

Summary:
When new JS dependencies are added, the flow server(s) need to be restarted to avoid inaccurate errors. In the past it's been on the developer to know this and run killall flow && flow (or the equivalent) to get their dev environment in working condition again. In this diff we just add that to the beginning of cleaninstall to take care of that for us.

killall is for macOS/Darwin (though they do have bsd pkill as well)
pkill is for Ubuntu/Debian/etc
true is for the case where there's no flow server running (eg very first run of yarn cleaninstall)

Test Plan: Ran yarn cleaninstall locally.. the pre-review CI will implicitly test things on Ubuntu/Debian

Reviewers: tomek, varun, marcin, abosh, ginsu, rohan

Reviewed By: varun

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D5223

Details

Provenance
atulAuthored on Sep 23 2022, 12:31 PM
Reviewer
varun
Differential Revision
D5223: [flow] Add `(killall flow || pkill flow || true)` to `cleaninstall`
Parents
rCOMMd4179e26b988: [native] Display thumbnail in `Multimedia` component for videos
Branches
Unknown
Tags
Unknown