HomePhabricator
Diffusion Comm 0d8f4bb46a79

[web] Make button size consistent between variants

Description

[web] Make button size consistent between variants

Summary:
Our button has different size depending on the variant, because secondary button has a border that increases its size. The issue isn't usually noticeable, but can be detected by using the debugger. It becomes visible when secondary and primary buttons are displayed in the same line.
The solution is for button to always have a border, which is transparent when the button is primary.

Test Plan: Checked in a couple of places if it still looks ok. There are places when sizing is slightly changed, because primary button is 2 pixels bigger, but the layout is ok in every place.

Reviewers: def-au1t, atul, yayabosh

Reviewed By: yayabosh

Subscribers: ashoat, Adrian

Differential Revision: https://phab.comm.dev/D4353

Details

Provenance
tomekAuthored on Jun 24 2022, 8:23 AM
Reviewer
abosh
Differential Revision
D4353: [web] Make button size consistent between variants
Parents
rCOMM64fe033c7e30: [web] Display user tags
Branches
Unknown
Tags
Unknown