Our button has different size depending on the variant, because secondary button has a border that increases its size. The issue isn't usually noticeable, but can be detected by using the debugger. It becomes visible when secondary and primary buttons are displayed in the same line.
The solution is for button to always have a border, which is transparent when the button is primary.
Details
Details
Checked in a couple of places if it still looks ok. There are places when sizing is slightly changed, because primary button is 2 pixels bigger, but the layout is ok in every place.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Yup, this makes sense to me. I think the difference in border size was overlooked in D3057, but nice catch!