[web] Merge store and server search results
ClosedPublic
Actions

Authored by tomek on Jun 14 2022, 7:37 PM.

Details

Reviewers

Commits

Summary

Merge the results from both sources and store them in a memo.

Depends on D4268

Test Plan

Render the component and check if merged result contains only the users matched by the search text.

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

tomek requested review of this revision.Jun 14 2022, 7:44 PM

atul added inline comments.

web/settings/relationship/add-users-list.react.js
44 ↗	(On Diff #13508)	Could maybe use `isSet` defined in `lib/shared/core.js`? It's essentially an alias for `blah !== null && blah !=undefined`
54 ↗	(On Diff #13508)	And could then change this to `isSet(searchTextPresent)`

This revision is now accepted and ready to land.Jun 17 2022, 8:30 PM

web/settings/relationship/add-users-list.react.js
44 ↗	(On Diff #13508)	This won't work because `searchText` is always non-null. What we should do instead is to check if it's empty.
54 ↗	(On Diff #13508)	The intention was for this memo to depend on a boolean flag instead of the text, so that changing the text wouldn't cause recomputation.