Page MenuHomePhabricator
Differential D4314

[web] Add buttons that open new modals
ClosedPublic
Actions

Authored by tomek on Jun 21 2022, 6:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 6, 5:23 AM
Unknown Object (File)
Sun, Apr 6, 5:23 AM
Unknown Object (File)
Sun, Apr 6, 5:23 AM
Unknown Object (File)
Sun, Apr 6, 5:22 AM
Unknown Object (File)
Thu, Apr 3, 12:22 AM
Unknown Object (File)
Sat, Mar 29, 11:05 AM
Unknown Object (File)
Wed, Mar 19, 9:32 AM
Unknown Object (File)
Mar 12 2025, 2:09 PM
View All Files
Subscribers
• abosh
• adrian
ashoat

Details

Reviewers
• jacek
atul
Commits
rCOMMae7313197cca: [web] Add buttons that open new modals
Summary

Add label and callback props to user list modal so that new modals can be opened. Set these props in block / friend list to appropriate modals.

list2.png (1×1 px, 140 KB)

list1.png (1×1 px, 118 KB)

Depends on D4313

Test Plan

Open friend list and check if it has a correct button that opens a modal where new friends can be added.
Open block list and check if it has a correct button that opens a modal where users can be blocked.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
web/
settings/
relationship/
11 lines
11 lines
30 lines
9 lines

Diff 13891

View Options

web/settings/relationship/block-list-modal.react.js

  • This file was added.
// @flow
import * as React from 'react';
import {
relationshipActions,
userRelationshipStatus,
} from 'lib/types/relationship-types.js';
import AddUsersListModal from './add-users-list-modal.react';
const excludedStatuses = new Set([
userRelationshipStatus.FRIEND,
userRelationshipStatus.BLOCKED_VIEWER,
userRelationshipStatus.BOTH_BLOCKED,
userRelationshipStatus.REQUEST_SENT,
userRelationshipStatus.REQUEST_RECEIVED,
]);
type Props = {
+onClose: () => void,
};
function AddFriendsModal(props: Props): React.Node {
const { onClose } = props;
return (
<AddUsersListModal
closeModal={onClose}
name="Add Friends"
excludedStatuses={excludedStatuses}
confirmButtonContent="Send Friend Requests"
relationshipAction={relationshipActions.FRIEND}
/>
);
}
export default AddFriendsModal;
View Options

web/settings/relationship/friend-list-modal.react.js

  • This file was added.
// @flow
import * as React from 'react';
import {
relationshipActions,
userRelationshipStatus,
} from 'lib/types/relationship-types.js';
import AddUsersListModal from './add-users-list-modal.react';
const excludedStatuses = new Set([
userRelationshipStatus.FRIEND,
userRelationshipStatus.BLOCKED_VIEWER,
userRelationshipStatus.BOTH_BLOCKED,
userRelationshipStatus.REQUEST_SENT,
userRelationshipStatus.REQUEST_RECEIVED,
]);
type Props = {
+onClose: () => void,
};
function AddFriendsModal(props: Props): React.Node {
const { onClose } = props;
return (
<AddUsersListModal
closeModal={onClose}
name="Add Friends"
excludedStatuses={excludedStatuses}
confirmButtonContent="Send Friend Requests"
relationshipAction={relationshipActions.FRIEND}
/>
);
}
export default AddFriendsModal;
View Options

web/settings/relationship/user-list-modal.react.js

  • This file was added.
// @flow
import * as React from 'react';
import {
relationshipActions,
userRelationshipStatus,
} from 'lib/types/relationship-types.js';
import AddUsersListModal from './add-users-list-modal.react';
const excludedStatuses = new Set([
userRelationshipStatus.FRIEND,
userRelationshipStatus.BLOCKED_VIEWER,
userRelationshipStatus.BOTH_BLOCKED,
userRelationshipStatus.REQUEST_SENT,
userRelationshipStatus.REQUEST_RECEIVED,
]);
type Props = {
+onClose: () => void,
};
function AddFriendsModal(props: Props): React.Node {
const { onClose } = props;
return (
<AddUsersListModal
closeModal={onClose}
name="Add Friends"
excludedStatuses={excludedStatuses}
confirmButtonContent="Send Friend Requests"
relationshipAction={relationshipActions.FRIEND}
/>
);
}
export default AddFriendsModal;
View Options

web/settings/relationship/user-list.css

  • This file was added.
// @flow
import * as React from 'react';
import {
relationshipActions,
userRelationshipStatus,
} from 'lib/types/relationship-types.js';
import AddUsersListModal from './add-users-list-modal.react';
const excludedStatuses = new Set([
userRelationshipStatus.FRIEND,
userRelationshipStatus.BLOCKED_VIEWER,
userRelationshipStatus.BOTH_BLOCKED,
userRelationshipStatus.REQUEST_SENT,
userRelationshipStatus.REQUEST_RECEIVED,
]);
type Props = {
+onClose: () => void,
};
function AddFriendsModal(props: Props): React.Node {
const { onClose } = props;
return (
<AddUsersListModal
closeModal={onClose}
name="Add Friends"
excludedStatuses={excludedStatuses}
confirmButtonContent="Send Friend Requests"
relationshipAction={relationshipActions.FRIEND}
/>
);
}
export default AddFriendsModal;