We don't want to display users that are friends when adding new friends, just like we don't want to do it for blocked users. To allow that, we can specify a set of excluded statuses.
Depends on D4305
Differential D4306
[web] Add option to filter users by status tomek on Jun 21 2022, 5:19 AM. Authored by Tags None Referenced Files
Details
We don't want to display users that are friends when adding new friends, just like we don't want to do it for blocked users. To allow that, we can specify a set of excluded statuses. Depends on D4305 Check if setting excluded statuses blocks the users with these from being displayed.
Diff Detail
Event TimelineComment Actions
As an aside, this seems like the type of thing we could relatively easily write tests for? Might be challenging to mock redux and whatnot though Comment Actions The easiest way of writing a test for this logic is to extract the function that computes a memo value and test it separately. If we want to test the whole component, we can also do that, but it's a matter of prioritization. |