Page MenuHomePhabricator

[web] Add option to filter users by status
ClosedPublic

Authored by tomek on Jun 21 2022, 5:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 2, 11:51 PM
Unknown Object (File)
Tue, Jul 2, 6:30 PM
Unknown Object (File)
Tue, Jul 2, 8:29 AM
Unknown Object (File)
Tue, Jul 2, 1:14 AM
Unknown Object (File)
Sun, Jun 30, 12:50 PM
Unknown Object (File)
Sat, Jun 29, 12:54 PM
Unknown Object (File)
Sat, Jun 15, 2:48 PM
Unknown Object (File)
Fri, Jun 14, 11:44 PM

Details

Summary

We don't want to display users that are friends when adding new friends, just like we don't want to do it for blocked users. To allow that, we can specify a set of excluded statuses.

Depends on D4305

Test Plan

Check if setting excluded statuses blocks the users with these from being displayed.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek requested review of this revision.Jun 21 2022, 5:24 AM

Check if setting excluded statuses blocks the users with these from being displayed.

As an aside, this seems like the type of thing we could relatively easily write tests for? Might be challenging to mock redux and whatnot though

This revision is now accepted and ready to land.Jun 21 2022, 10:17 AM
In D4306#121576, @atul wrote:

Check if setting excluded statuses blocks the users with these from being displayed.

As an aside, this seems like the type of thing we could relatively easily write tests for? Might be challenging to mock redux and whatnot though

The easiest way of writing a test for this logic is to extract the function that computes a memo value and test it separately. If we want to test the whole component, we can also do that, but it's a matter of prioritization.

This revision was automatically updated to reflect the committed changes.