The modal uses search modal internally and can be configured by setting name, labels and action (friend / block).
Depends on D4310
Details
Details
Render the modal with some props and check if it looks correctly - it should match friend / block list modal.
Check if users are filtered according to excludedStatuses and if clicking the confirm button updates their status.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| web/settings/relationship/add-users-list-modal.react.js | ||
|---|---|---|
| 50 ↗ | (On Diff #13626) | It seems a little strange to me that we're passing this generator function as the child prop of SearchModal I'm used to the children prop being typed as React.Node or string... but I guess this makes sense the way SearchModal is being re-used |
| web/settings/relationship/add-users-list-modal.react.js | ||
|---|---|---|
| 50 ↗ | (On Diff #13626) | Agree it's weird to use children like this, but I've previously been convinced about @palys-swm on it in some scenario (don't think it was SearchModal, but maybe). @palys-swm can you remind me what the justification is here? |
| web/settings/relationship/add-users-list-modal.react.js | ||
|---|---|---|
| 50 ↗ | (On Diff #13626) | It was the same component - SearchModal. I described the rationale in the comment https://phab.comm.dev/D3494#96476 |